bump argo submodule

[pnwamk]

No description provided.

[jpaykin]

I got the following error when building on this branch, does CryptolServer.Data.Type (in cryptol/cryptol-remote-api) need to be updated to deal with the updated JSON representation?

[ 1 of 16] Compiling CryptolServer.Data.Type ( src/CryptolServer/Data/Type.hs, /home/jennifer/work/PICARD/saw-script/dist-newstyle/build/x86_64-linux/ghc-8.10.7/cryptol-remote-api-0.1.0.0/build/CryptolServer/Data/Type.o, /home/jennifer/work/PICARD/saw-script/dist-newstyle/build/x86_64-linux/ghc-8.10.7/cryptol-remote-api-0.1.0.0/build/CryptolServer/Data/Type.dyn_o ) [Cryptol.Utils.RecordMap changed]

src/CryptolServer/Data/Type.hs:222:25: error:
    • Couldn't match expected type ‘JSON.Key’ with actual type ‘T.Text’
    • In the first argument of ‘(.=)’, namely ‘T.pack (show (pp f))’
      In the expression: T.pack (show (pp f)) .= JSONType ns t'
      In the first argument of ‘JSON.object’, namely
        ‘[T.pack (show (pp f)) .= JSONType ns t' |
            (f, t') <- canonicalFields fields]’
    |
222 |           JSON.object [ T.pack (show (pp f)) .= JSONType ns t'
    |                         ^^^^^^^^^^^^^^^^^^^^

src/CryptolServer/Data/Type.hs:234:35: error:
    • Couldn't match type ‘Data.Aeson.KeyMap.KeyMap JSON.Value’
                     with ‘HM.HashMap k0 a0’
      Expected type: HM.HashMap k0 a0
        Actual type: JSON.Object
    • In the second argument of ‘HM.lookup’, namely ‘o’
      In the expression: HM.lookup "type" o
      In the expression:
        case HM.lookup "type" o of
          Just t -> asType t o
          Nothing
            -> case HM.lookup "prop" o of
                 Just p -> asProp p o
                 Nothing -> fail "Expected type or prop key"
    |
234 |             case HM.lookup "type" o of
    |                                   ^

src/CryptolServer/Data/Type.hs:237:39: error:
    • Couldn't match type ‘Data.Aeson.KeyMap.KeyMap JSON.Value’
                     with ‘HM.HashMap k1 a1’
      Expected type: HM.HashMap k1 a1
        Actual type: JSON.Object
    • In the second argument of ‘HM.lookup’, namely ‘o’
      In the expression: HM.lookup "prop" o
      In the expression:
        case HM.lookup "prop" o of
          Just p -> asProp p o
          Nothing -> fail "Expected type or prop key"
    |
237 |                 case HM.lookup "prop" o of
    |

[pnwamk]

does CryptolServer.Data.Type (in cryptol/cryptol-remote-api) need to be updated to deal with the updated JSON representation?

Ah, that could be. This might need to be a slightly more complicated fix. I'll take a look.

[pnwamk]

We probably need to update some code to either check for the aeson version (as is done here) or create an upper bound to avoid the breaking change in aeson for now (see #1486).

[pnwamk]

#1486 solves the issue this PR intended (and failed) to.