Make scanl a SAWCore primitive #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robdockins
force-pushed
the
coq-primitives
branch
from
c1426e0
to
3667b04
Compare
|
The loss of sharing with infinite streams will be a problem, and we should fix that before merging this. Cryptol's |
more likely for coercions to simplify away.
`ecScanl` as an implemention for the Cryptol `scanl` primitive.
when we can easily tell that the length of the branches are the same. This avoids unneccessary coercions. Fixes #1507
This restores the term sharing behavior of `scanl` and `iterate` on infinite streams.
it instead of the SAWCore implementation.
This recursively unfolds lets appearing in the goal, as otherwise the proof automation falls completely over.
robdockins
force-pushed
the
coq-primitives
branch
from
3667b04
to
3558a5f
Compare
|
@brianhuffman, I think I've fixed the loss of sharing issue now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in further support of Cryptol->Coq extraction.
One point I'm unsure about. In the definition of
scanlfor infinite streams, I put in a fairly naive implementation that computes each position independently. This will result in a total loss of sharing. TheiterateCryptol primitive is now defined in terms ofscanl, so it will also have this issue. I'm not sure if this is something we should worry about.