Heapster: freshen LLVM global names #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 2, 2021 15:51
…with the same name do not create name clashes
eddywestbrook
added
the
subsystem: heapster
|
@brianhuffman: The reason I'm asking for your review is that almost all of this change is just to add the new function |
brianhuffman
approved these changes
Dec 3, 2021
eddywestbrook
added
the
PR: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where LLVM globals with the same names (in different bitcode files) were causing name clashes. Now they are translated to SAW core definitions with fresh names.
To achieve this, this PR also adds a new operator
scFreshenGlobalIdentto SharedTerm.hs.