Heapster: use unsafeAssert for translating BVProps known to hold #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… known to hold to translate the SAW core unsafeAssert function
|
Whoops, the |
added 2 commits
December 19, 2021 07:57
…sertions solveUnsafeAssertBVULt and solveUnsafeAssertBVULe
m-yac
approved these changes
Dec 20, 2021
m-yac
added
subsystem: heapster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the translation of the
Impl1_TryProveBVProprule for BVProps that are known to hold statically so that they callunsafeAssert, rather than requiring them to be proved by the automation later. The issue was that SAW core equalities on bitvectors do not compute, even though they do in Coq, but translating tounsafeAssertsolves the problem in SAW core, and these calls are then translated to Coq reflexivity proofs.