[Heapster] Don't use Coq let-bindings in Heapster specs #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-yac
added
the
subsystem: heapster
m-yac
added
the
PR: ready to merge
m-yac
force-pushed
the
heapster/sawLet
branch
from
2e90b90
to
02ecc7c
Compare
m-yac
removed
the
PR: ready to merge
eddywestbrook
added
the
PR: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a function
sawLetto thesaw-corePrelude which is used in Heapster instead ofsaw-core's usual sharing mechanism to ensure certain shared variables are not translated to Coq let-bindings. This is because Coq very much likes to unfold let-bindings, which is bad for examples in which unfolding let-bindings results in exponential explosion (see theexp_explosionexample added in this PR). By having an explicit function (sawLet), we can control when we unfold in the proof automation.This PR also cleans up the SHA512 example.