-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heapster: more rust bugfixes #1574
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… longer determined
…dMods to introduce an eliminate just the modalities on named shapes
…prove a recursive shape on the right
…a time; added a FIXME for only storing whole multiples of bytes
…f the lowned permission with the actual permissions that are borrowed
…ission, which has the same permissions on input and output
…irst; also changed implLLVMFieldTryProveWordEq to not drop equality permissions
…id out as pointers to values, the return permissions need to give back the memory where they were as an empty memblock permission
…d by value to called functions
… stop deciding option-like-ness if no such element is found
…er variants carry no data
…w-script into heapster/more-rust-bugfixes
…ape with an unneeded empty shape
…s lowned permission contains undetermined vars, not just when the lifetime itself is not determined
…ype; and added an assumption for the clone method for Box<List20<u64>>
The main changes in this PR are:
|
m-yac
approved these changes
Feb 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with the usual caveat that I wasn't able to fully understand the changes in Implication.hs
and RustTypes.hs
, so I mostly just looked over those files for style. If all the tests pass though, this is good to merge.
m-yac
added
the
PR: ready to merge
Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
label
Feb 9, 2022
m-yac
added
the
subsystem: heapster
Issues specifically related to memory verification using Heapster
label
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
PR: ready to merge
Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
subsystem: heapster
Issues specifically related to memory verification using Heapster
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a number of bug fixes for running Heapster on code compiled from Rust.