MR Solver SMT fixes for testing on Heapster models #1594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 25 commits
February 11, 2022 16:56
… making it normalize the input type before deciding if it is already computational
… just globals but also (tuple and record) projections of globals
…that we do not pass the SMT solver uvars that do not occur in the proposition we want to prove
…titute outer instantiations into the types of inner ones as it goes
…ninterpreted functions in place of variable-length vectors
…oposition by adding an EqTrue
…andle vector values
… by proving equality at all indices
…tx; fixed a bug in withUVar, that assumptions added under the extended context should be thrown away when that context ends
…tx; fixed a bug in withUVar, that assumptions need to be lifted in the new context and then reverted when that context ends
…cript into mr-solver/heapster-tests
…ged variable instantiation in mrProvable to use the normalized types
…var being instantiated; trying to figure out why my uninterpreted functions do not work when passing them to the SMT solver...
m-yac
suggested changes
Feb 22, 2022
m-yac
approved these changes
Feb 22, 2022
m-yac
added
the
PR: ready to merge
m-yac
added
the
subsystem: MRSolver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a number of bugs in the way MR Solver calls out to SMT, in order to enable it to run on models extracted from Heapster. Specifically, it adds support for representing vectors of type
BVVecwith symbolic lengths in SMT solvers, by transforming them to uninterpreted functions.This change also adds support for refinement of the
maybeeliminator.