Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error in permForLLVMArrayBorrow #1614

Merged
merged 2 commits into from
Mar 22, 2022
Merged

Fix error in permForLLVMArrayBorrow #1614

merged 2 commits into from
Mar 22, 2022

Conversation

abakst
Copy link
Contributor

@abakst abakst commented Mar 16, 2022

permForLLVMArrayBorrow currently does not handle non-zero offset arrays correctly, this patch changes that.

Tested by running make in heapster-saw/examples

@abakst abakst force-pushed the fix-permForLLVMArrayBorrow branch from 7c0b74c to 308e87f Compare March 16, 2022 22:19
eddywestbrook
eddywestbrook approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@eddywestbrook eddywestbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, yep, that was a bug!

@eddywestbrook eddywestbrook added PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run subsystem: heapster Issues specifically related to memory verification using Heapster labels Mar 22, 2022
@mergify mergify bot merged commit dbab6e9 into master Mar 22, 2022
@mergify mergify bot deleted the fix-permForLLVMArrayBorrow branch March 22, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddywestbrook eddywestbrook eddywestbrook approved these changes

Assignees

@abakst abakst

@eddywestbrook eddywestbrook

Labels
PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run subsystem: heapster Issues specifically related to memory verification using Heapster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abakst @eddywestbrook