-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRSolver] Changes to Mr. Solver to get zero_array working #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… mr-solver/heterogeneous
m-yac
added
the
subsystem: MRSolver
Issues related to the Mr. Solver monadic-recursive solver in Heapster
label
Mar 23, 2022
eddywestbrook
approved these changes
Mar 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks Matt!
eddywestbrook
added
the
PR: ready to merge
Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
label
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
PR: ready to merge
Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
subsystem: MRSolver
Issues related to the Mr. Solver monadic-recursive solver in Heapster
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets an example of exponential explosion (
exp_explosion_mr_solver.saw
) and a Cryptol refinement proof ofzero_array
(arrays_mr_solver.saw
) working with Mr. Solver.The main changes needed to get these working were:
Vec n Bool
can now refine a function with corresponding argument typeNum
(or vice versa) by introducing the former and substitutingTCNum
ofbvToNat n
of the former for the latterseqMapM
in terms ofmultiFixM
with a loop invariant (so that Mr. Solver can do co-induction on list comprehensions) and special-case it if its length argument isbvToNat
of some bitvector (so that we can easily translate to SMT)ecUpdate
and tweak the monadification ofecAt
to better work with Mr. SolverinvariantHint
to ensure an application ofinvariantHint
remains top-level (i.e. so thatinvariantHint a cond comp
monadifies toinvariantHint (CompM a) cond comp
and notcomp >>= \x -> returnM a (invariantHint a cond x)
)asserting
andassuming
(for the same reason as the above) and add special cases for them to Mr. Solver (for better error reporting)y
, callingset_monadification x y
will now add the same macro forx
. This is needed so that inspecPrims.saw
,set_monadification "invariantHint" "Prelude.invariantHint"
does the macro described above instead of just monadifying it toPrelude.invariantHint
and stopping there - the same goes forassuming
andasserting
. (This could probably also be solved by recursing inmonadifyTerm
, but this seemed simpler.)bvNat w (bvToNat w' n)
reduce ton
in the SAW core simulator