Use modalities in solving for lowned permissions #1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 3, 2022 13:00
…e rw and lifetime modalities to it
eddywestbrook
added
the
subsystem: heapster
ChrisEPhifer
approved these changes
May 4, 2022
ChrisEPhifer
added
the
PR: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
solveForPermListImplfunction used for figuring out what permissions currently held on a variablexneed to be added to prove an implication of lifetime ownership permissions. Specifically, this change incorporates the read/write and lifetime modalities into theMbRangeForTypetype, meaning thatsolveForPermListImplnow takes these modalities into account when solving for these permissions. This PR also removes theMbRangeForStructTypeconstructor, since after thinking about it some that doesn't really make sense...