Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add heterogenous equality to Mr. Solver for SHA512 example #1670

Merged
merged 7 commits into from
May 19, 2022

Conversation

m-yac
Copy link
Contributor

@m-yac m-yac commented May 19, 2022

This PR gets round_16_80 |= round_16_80_spec from the SHA512 example working by primarily adding heterogeneous equality to Mr. Solver. It also makes a few other changes, but instead of listing them here, I broke each change into its own commit. Each commit should be self-explanatory.

I'm not totally sure about the interface choices I made in SMT.hs in 45de464 (e.g. mrProveEq vs. mrProveRel, using a Bool to indicate heterogeneous equality), so that's definitely worth taking a look at. It's worth saying that I went for mrProveRel instead of something like mrProveHetEq because we will likely eventually want to add a parameter to this function which additionally lets the user give a custom relation for function terms (for lifetimes).

@m-yac m-yac added the subsystem: MRSolver Issues related to the Mr. Solver monadic-recursive solver in Heapster label May 19, 2022
@m-yac m-yac requested a review from eddywestbrook May 19, 2022 00:23
Copy link
Contributor

@eddywestbrook eddywestbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@eddywestbrook eddywestbrook added the PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run label May 19, 2022
@eddywestbrook eddywestbrook merged commit 5f603a3 into master May 19, 2022
@mergify mergify bot deleted the mr-solver/sha512-2 branch May 19, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run subsystem: MRSolver Issues related to the Mr. Solver monadic-recursive solver in Heapster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants