Fix #1691 by bringing in GaloisInc/crucible#1004 #1695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that the `crucible-llvm` memory model has a fix for GaloisInc/crucible#1004, bumping the `crucible` submodule to bring in that change fixes #1691 as a consequence. I have also added a regression test.
RyanGlScott
added
subsystem: crucible-llvm
chameco
approved these changes
Jun 24, 2022
RyanGlScott
added
the
PR: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the
crucible-llvmmemory model has a fix for GaloisInc/crucible#1004, bumping thecruciblesubmodule to bring in that change fixes #1691 as a consequence. I have also added a regression test.