Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1684 by bringing in GaloisInc/crucible#998 #1696

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Fix #1684 by bringing in GaloisInc/crucible#998 #1696

merged 1 commit into from
Jun 28, 2022

Conversation

RyanGlScott
Copy link
Contributor

Now that the crucible-llvm memory model can reason about struct padding with lax-loads-and-stores enabled, bumping the crucible submodule to bring in that change fixes #1684 as a consequence. I have also added a regression test.

This also bumps the macaw submodule to bring in GaloisInc/macaw#299, which adapts macaw to the aforementioned crucible-llvm changes.

@RyanGlScott
Fix #1684 by bringing in GaloisInc/crucible#998
d63f36a 
Now that the `crucible-llvm` memory model can reason about struct padding
with `lax-loads-and-stores` enabled, bumping the `crucible` submodule to bring
in that change fixes #1684 as a consequence. I have also added a regression
test.
@RyanGlScott RyanGlScott requested a review from chameco June 28, 2022 17:32
chameco
chameco approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@chameco chameco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test!

@RyanGlScott RyanGlScott added the PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run label Jun 28, 2022
@mergify mergify bot merged commit cf5684f into master Jun 28, 2022
@mergify mergify bot deleted the T1684 branch June 28, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chameco chameco chameco approved these changes

Assignees
No one assigned
Labels
PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic with enable_lax_loads_and_stores and nested structs
2 participants
@RyanGlScott @chameco