[crux-mir-comp] struct support for munge #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
The StructShape case looks good.
I have set the base for this PR to the crux-mir-comp-readme branch. Please let me know if I should merge against master instead.
Yes, please rebase this branch onto master and retarget the PR. crux-mir-comp-readme is readme changes only, so you shouldn't run into any trouble working off master instead.
|
Sorry about the force-pushes. Rebased the branch on to an old |
plredmond
commented
Jul 22, 2022
spernsteiner
approved these changes
Jul 22, 2022
|
Just pushed the golden file for the test. I'll add the ready to merge label. |
|
I don't have perms to add labels. |
spernsteiner
added
the
PR: ready to merge
RyanGlScott
added
the
subsystem: crucible-mir
RyanGlScott
added
the
subsystem: crucible-mir-comp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@spernsteiner I did not see tests for
mungein thecrux-mir-comp/package directory. Also, I have set the base for this PR to thecrux-mir-comp-readmebranch. Please let me know if I should merge againstmasterinstead.