saw-core-coq: Explicitly define atWithProof, genWithProof, and friends
#1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saw-core-coq/src/Verifier/SAW/Translation/Coq/SpecialTreatment.hs
Outdated
Show resolved
Hide resolved
To avoid unnecessary breakage in the Coq support libraries, we keep `bvNat_bvToNat_id` around as a deprecated alias for `bvNat_bvToNat`. Fixes #1785.
RyanGlScott
force-pushed
the
atGenWithProof
branch
from
d6e9138
to
d4951ae
Compare
eddywestbrook
approved these changes
Dec 12, 2022
This provides explicit Coq definitions for SAWCore's `atWithProof` and `genWithProof` functions, which allow them to compute. It also proves the auxiliary `at_gen_BVVec` and `gen_at_BVVec` lemmas, a feat which is now possible thanks to the aforementioned computability. To make this work with the current module ordering, I needed to wire in the definition of `IsLtNat` into `SAWCoreScaffolding`, which proves straightforward. Fixes #1784.
The `SpecialTreatment` module had two entirely duplicate definitions (`sawCoreScaffoldingModule` and `sawDefinitionsModule`) referring to the `SAWCoreScaffolding` module. Let's delete the former in favor of the latter, which is more widely used.
RyanGlScott
force-pushed
the
atGenWithProof
branch
from
d4951ae
to
2e268b6
Compare
RyanGlScott
added
the
PR: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides explicit Coq definitions for SAWCore's
atWithProofandgenWithProoffunctions, which allow them to compute. It also proves the auxiliaryat_gen_BVVecandgen_at_BVVeclemmas, a feat which is now possible thanks to the aforementioned computability.Fixes #1784.