Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update monadification and MR solver to work with the SpecM monad #1806

Merged
merged 31 commits into from
Jan 26, 2023

Conversation

eddywestbrook
Copy link
Contributor

This command updates MR solver and the cryptol monadification transformation to use the new SpecM monad in place of the older CompM monad. Most of the changes were relatively straightforward replacements of the constructs for the one for the corresponding constructs of the other. The monadification and MR solver tests have also been updated so that they continue to work with the new versions.

Eddy Westbrook and others added 28 commits December 5, 2022 14:53
…upport to normComp for normalizing multiArgFixS
…hat are polymorphic over the event type and fun stack params
@eddywestbrook eddywestbrook added the subsystem: MRSolver Issues related to the Mr. Solver monadic-recursive solver in Heapster label Jan 25, 2023
Copy link
Contributor

@m-yac m-yac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just pushed a style tweak to the way constraints were formatted in Monadify.hs, hope that's alright – I changed HasCallStack => HasSpecMParams => ... to (HasCallStack, HasSpecMParams) => ....

@eddywestbrook eddywestbrook added the PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run label Jan 26, 2023
@mergify mergify bot merged commit acbf303 into master Jan 26, 2023
@mergify mergify bot deleted the heapster-itree-mr-solver-alt branch January 26, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run subsystem: MRSolver Issues related to the Mr. Solver monadic-recursive solver in Heapster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants