Fix the build with alex-3.2.7.2
#1855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`alex-3.2.7.2` generates code that uses `PatternGuards`, but because `saw-core` does not specify a `default-language` in its `.cabal` file, it defaults to `Haskell98`, which does not include `PatternGuards`. Arguably, we should make `saw-core`'s `default-language` be `Haskell2010` (which _does_ include `PatternGuards`), but that would be a somewhat larger change. For the sake of restoring the build, this applies the simplest possible fix of enabling `PatternGuards` in the affected file. Fixes #1854.
|
Thank you for your quick action on this problem. |
RyanGlScott
added
the
PR: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alex-3.2.7.2generates code that usesPatternGuards, but becausesaw-coredoes not specify adefault-languagein its.cabalfile, it defaults toHaskell98, which does not includePatternGuards. Arguably, we should makesaw-core'sdefault-languagebeHaskell2010(which does includePatternGuards), but that would be a somewhat larger change. For the sake of restoring the build, this applies the simplest possible fix of enablingPatternGuardsin the affected file.Fixes #1854.