Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Upgrade Poetry version #1866

Merged
merged 2 commits into from
May 10, 2023
Merged

CI: Upgrade Poetry version #1866

merged 2 commits into from
May 10, 2023

Conversation

RyanGlScott
Copy link
Contributor

The version we were previously using (1.1.5) is affected by this bug, causing invocations of Poetry to fail:
psf/cachecontrol#292

@RyanGlScott
Copy link
Contributor Author

After downgrading to Poetry 1.3.2 (see python-poetry/poetry#7892), the saw-remote-api tests now pass. Alternatively, we could employ the workaround described in https://github.com/python-poetry/poetry/issues/7892#issuecomment-1539073618—thoughts, @kquick?

The version we were previously using (1.1.5) is affected by this bug, causing
invocations of Poetry to fail:
psf/cachecontrol#292
@RyanGlScott RyanGlScott marked this pull request as draft May 9, 2023 17:22
@RyanGlScott
Copy link
Contributor Author

Never mind, there is an alternative solution that allows us to use Poetry 1.4.2 by switching out setuptools for a different build backend, as described in python-poetry/poetry#7892 (comment). I've implemented this approach, and CI passes.

This is motivated by a desire to switch away from `setuptools`, which has some
unfortunate interactions with static analysis tools.

This also bumps the following submodules, which apply similar changes:

* `argo` submodule: GaloisInc/argo#197
* `cryptol` submodule: GaloisInc/cryptol#1519
@RyanGlScott RyanGlScott marked this pull request as ready for review May 9, 2023 23:38
@RyanGlScott RyanGlScott added the PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run label May 9, 2023
@mergify mergify bot merged commit e170f15 into master May 10, 2023
@mergify mergify bot deleted the upgrade-poetry branch May 10, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants