Yosys: Support compositional translation of sequential circuits #1880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanGlScott
reviewed
Jun 20, 2023
There was a problem hiding this comment.
I am not at all an expert on the Yosys backend, so this is a very shallow review of the code. Let me know if there are parts that you think deserve closer scrutiny.
Also, do you think the Yosys backend is develop enough at this point to include more user-facing documentation, such as in the SAW manual and/or changelog?
|
@RyanGlScott I think this is ready to merge, with your approval.
Sam added a manual section in response to this. |
RyanGlScott
approved these changes
Aug 10, 2023
Co-authored-by: Ryan Scott <rscott@galois.com>
bboston7
added
the
PR: ready to merge
RyanGlScott
added a commit
that referenced
this pull request
Feb 1, 2024
RyanGlScott
added a commit
that referenced
this pull request
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for compositional translation of sequential circuits to the Yosys backend. In practice, this is a large refactoring of the
yosys_importcommand - this command formerly supported only combinational circuits, but the changes here extend it to also support sequential circuits.