-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add llvm_ffi_setup
command
#1940
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qsctr
added
the
type: enhancement
Issues describing an improvement to an existing feature or capability
label
Sep 16, 2023
Merged
qsctr
changed the title
Add
Add Oct 2, 2023
llvm_ffi_setup
commandllvm_ffi_setup
and llvm_ffi_verify
@andreistefanescu doesn't want to add |
qsctr
changed the title
Add
Add Oct 3, 2023
llvm_ffi_setup
and llvm_ffi_verify
llvm_ffi_setup
command
andreistefanescu
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
qsctr
added
the
PR: ready to merge
Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
label
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
PR: ready to merge
Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
type: enhancement
Issues describing an improvement to an existing feature or capability
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
llvm_ffi_setup
command, which generates aLLVMSetup
spec that can be used to verify a Cryptol foreign function implementation in LLVM against its reference Cryptol specification.The code supports all Cryptol types that are supported by the Cryptol FFI, with the exception of
Integer
,Rational
, andZ
, since those usegmp
which would be hard for SAW to handle without additional overrides. Support for Cryptol floating point types is implemented here, but remains unimplemented in SAW Core (#1237), so we can generate the spec for floating point types butllvm_verify
won't be able to actually do the verification.Two integration tests are included:
test_ffi_verify
extends the Cryptol FFI test suite'stest-ffi
module with Cryptol implementations for most foreign functions, and verifies them withllvm_ffi_setup
andllvm_verify
.test_ffi_verify_salsa
is a more nontrivial test which verifies djb's Salsa20 reference implementation, as a Cryptol foreign function, against the spec fromcryptol-specs
, similar to @WeeknightMVP's example.See the manual for more documentation.
Closes #1842.
TODO:
llvm_ffi_verify