Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iss-1932 #1949

Merged
merged 3 commits into from
Sep 28, 2023
Merged

iss-1932 #1949

merged 3 commits into from
Sep 28, 2023

Conversation

mccleeary-galois
Copy link
Contributor

#1932

Fixes and adds a test for issue noted above.

RyanGlScott
RyanGlScott reviewed Sep 28, 2023
View reviewed changes
Copy link
Contributor

@RyanGlScott RyanGlScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor suggestions, but otherwise this LGTM. Thanks, @mccleeary-galois!

intTests/test_llvm_bound_check/Makefile Outdated Show resolved Hide resolved
intTests/test_llvm_bound_check/test.sh Outdated Show resolved Hide resolved
@mccleeary-galois mccleeary-galois added the PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run label Sep 28, 2023
@mergify mergify bot merged commit 1fd52b9 into master Sep 28, 2023
40 checks passed
@mergify mergify bot deleted the rem/iss-1932 branch September 28, 2023 19:59
@RyanGlScott RyanGlScott mentioned this pull request Sep 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanGlScott RyanGlScott RyanGlScott approved these changes

Assignees
No one assigned
Labels
PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mccleeary-galois @RyanGlScott