Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding integration test for hash table #1950

Merged
merged 3 commits into from
Sep 30, 2023
Merged

adding integration test for hash table #1950

merged 3 commits into from
Sep 30, 2023

Conversation

mccleeary-galois
Copy link
Contributor

No description provided.

RyanGlScott
RyanGlScott reviewed Sep 28, 2023
View reviewed changes
Copy link
Contributor

@RyanGlScott RyanGlScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mccleeary-galois! I have two inline suggestions, but otherwise this looks good to me.

intTests/test_hash_table/ht_simplified.c Outdated Show resolved Hide resolved
intTests/test_hash_table/Makefile Outdated Show resolved Hide resolved
@mccleeary-galois mccleeary-galois added the PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run label Sep 28, 2023
@RyanGlScott RyanGlScott added PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run and removed PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run labels Sep 30, 2023
@RyanGlScott RyanGlScott merged commit c241b02 into master Sep 30, 2023
38 of 40 checks passed
@RyanGlScott RyanGlScott deleted the rem/hash-table-int-test branch September 30, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanGlScott RyanGlScott RyanGlScott approved these changes

Assignees
No one assigned
Labels
PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mccleeary-galois @RyanGlScott