Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unfolding_fix_once. #2008

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Add unfolding_fix_once. #2008

merged 3 commits into from
Jan 16, 2024

Conversation

andreistefanescu
Copy link
Contributor

No description provided.

RyanGlScott
RyanGlScott reviewed Jan 15, 2024
View reviewed changes
src/SAWScript/Proof.hs Outdated Show resolved Hide resolved
saw-core/src/Verifier/SAW/SharedTerm.hs Show resolved Hide resolved
kquick
kquick reviewed Jan 15, 2024
View reviewed changes
Copy link
Member

@kquick kquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some documentation and refactoring suggestions, but otherwise this looks good. I would mark this as approved but mergify would take over; let me know when you are satisfied and I'm happy to approve at that point.

saw-core/src/Verifier/SAW/SharedTerm.hs Show resolved Hide resolved
src/SAWScript/Interpreter.hs Outdated Show resolved Hide resolved
@andreistefanescu andreistefanescu merged commit 29af202 into master Jan 16, 2024
38 checks passed
@mergify mergify bot deleted the unfolding_fix_once branch January 16, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanGlScott RyanGlScott RyanGlScott approved these changes

@kquick kquick kquick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreistefanescu @kquick @RyanGlScott