Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add {jvm,mir}_equal commands #2151

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Add {jvm,mir}_equal commands #2151

merged 2 commits into from
Nov 14, 2024

Conversation

RyanGlScott
Copy link
Contributor

These mirror the existing llvm_equal command in the LLVM backend. I have factored out whatever code shared in common that I could.

Fixes #1998.

Copy link
Collaborator

@sauclovian-g sauclovian-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you forgot to add one of the test.sh files. Other than that, LGTM.

(I guess: Is there anywhere in the docs that these should be added? There ought to be but I suspect currently there is not...)

@RyanGlScott
Copy link
Contributor Author

Looks like you forgot to add one of the test.sh files.

Oops! Good catch. I've added this now.

Is there anywhere in the docs that these should be added?

Indeed, these ought to be mentioned near the existing manual entry for llvm_equal. I've done so now.

doc/manual/manual.md Outdated Show resolved Hide resolved
These mirror the existing `llvm_equal` command in the LLVM backend. I have
factored out whatever code shared in common that I could.

Fixes #1998.
@RyanGlScott RyanGlScott merged commit 6fd40d6 into master Nov 14, 2024
34 checks passed
@RyanGlScott RyanGlScott deleted the T1998-jvm_mir_equal branch November 14, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add mir_equal and jvm_equal commands, similar to llvm_equal
2 participants