Check bitvector types in crucible_llvm_extract
#567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 16, 2019 15:53
Because `crucible-llvm` merges integer and pointer types, it is not sufficient to look at Crucible types to determine whether a CFG coming from LLVM takes pointer arguments or returns a pointer. Instead, we have to look at the original LLVM types. This commit does that, and produces an error if `crucible_llvm_extract` is used with a function that has poiinter types anywhere in its signature. Fixes #521.
Ptival
pushed a commit
that referenced
this pull request
Oct 31, 2019
Because `crucible-llvm` merges integer and pointer types, it is not sufficient to look at Crucible types to determine whether a CFG coming from LLVM takes pointer arguments or returns a pointer. Instead, we have to look at the original LLVM types. This commit does that, and produces an error if `crucible_llvm_extract` is used with a function that has poiinter types anywhere in its signature. Fixes #521.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.