Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for "inlined" x86_64 calls #802

Merged
merged 3 commits into from
Aug 11, 2020
Merged

Add support for "inlined" x86_64 calls #802

merged 3 commits into from
Aug 11, 2020

Conversation

chameco
Copy link
Contributor

@chameco chameco commented Aug 4, 2020

Previously, crucible_llvm_verify_x86 did not properly handle functions using the call instruction.

andreistefanescu
andreistefanescu approved these changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@andreistefanescu andreistefanescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chameco chameco merged commit bacae1a into master Aug 11, 2020
@brianhuffman brianhuffman mentioned this pull request Dec 9, 2020
Closed
@RyanGlScott RyanGlScott added the subsystem: x86 Issues related to verifying x86 binaries via Macaw label Dec 6, 2021
@RyanGlScott RyanGlScott deleted the x86-inline-calls branch March 22, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreistefanescu andreistefanescu andreistefanescu approved these changes

Assignees
No one assigned
Labels
subsystem: x86 Issues related to verifying x86 binaries via Macaw
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chameco @andreistefanescu @RyanGlScott