Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some unused BuiltinContext and Options parameters. #949

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Remove some unused BuiltinContext and Options parameters. #949

merged 1 commit into from
Dec 4, 2020

Conversation

brianhuffman
Copy link
Contributor

Fixes #945.

@brianhuffman brianhuffman force-pushed the remove-bic-opts branch 2 times, most recently from 25a31a8 to aee45b8 Compare December 4, 2020 03:19
atomb
atomb approved these changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@atomb atomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes things look much cleaner. Thanks!

Remove some unused BuiltinContext and Options parameters.
a15f6a4 
Removing those parameters also necessitated the addition of
a `roBasicSS` field to the `TopLevelRO` datatype.

Fixes #945.
@brianhuffman brianhuffman merged commit 6f73c07 into master Dec 4, 2020
@brianhuffman brianhuffman deleted the remove-bic-opts branch December 4, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomb atomb atomb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove BuiltinContext and Options arguments from functions
2 participants
@brianhuffman @atomb