Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps #992

Merged
merged 4 commits into from
Jan 7, 2021
Merged

Update deps #992

merged 4 commits into from
Jan 7, 2021

Conversation

brianhuffman
Copy link
Contributor

No description provided.

Brian Huffman added 3 commits January 6, 2021 16:00
This patch includes PR GaloisInc/crucible#589.

Functions `doFieldStore` and `doFieldLoad` now take a `FieldId`
instead of just a `String`.
@brianhuffman
Copy link
Contributor Author

There's a new failure in aws-lc-verification that I have just reproduced locally (and which doesn't happen in master). I'll investigate to see which submodule change causes the problem.

@brianhuffman
Copy link
Contributor Author

The failure already happens in 58e511c, the first commit in this PR.

@brianhuffman
Copy link
Contributor Author

brianhuffman commented Jan 7, 2021

Bisection on macaw shows that the failure is related to GaloisInc/macaw#183.

@chameco, do you have a patch for aws-lc-verification that goes along with this? If so, we can update the git hash for the aws-lc-verification repo in the CI script. If not, I can add another commit to this PR to "un-bump" the macaw version.

@chameco
Copy link
Contributor

chameco commented Jan 7, 2021

I believe that GaloisInc/aws-lc-verification@7f648ff will resolve this for now, at least.

@brianhuffman
Copy link
Contributor Author

It looks like that revision is working locally for me. I just pushed a patch to the dockerfile to use that revision, so I expect the CI tests to pass now. Thanks, @chameco!

Now that there's a reference to it from saw-script, we should make sure that git commit gets merged into the aws-lc-verification master branch, so that it won't disappear.

@brianhuffman
Copy link
Contributor Author

Now the blst test has failed, probably due to #991. Perhaps we should merge a fix for that first.

Copy link
Contributor

@andreistefanescu andreistefanescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants