Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update submodule location for llvm-pretty and dismantle #82

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

mccleeary-galois
Copy link
Contributor

Fix #81

@mccleeary-galois
Copy link
Contributor Author

semmc is not compatible with the most recent version of crucible it appears, going to cut a ticket for that and leave it for now.

@kquick kquick changed the title Update submodule location for llvm-pretty Update submodule location for llvm-pretty and dismantle Jun 12, 2024
Copy link
Member

@kquick kquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to change the location but keep the same hash reference, so that it's still building the same versions of the code. Then we can change the hash references to newer versions in a separate PR effort.

@RyanGlScott
Copy link
Collaborator

The failure doesn't really have anything to do with semmc itself—it's because you are bumping the llvm-pretty submodule to a version that is incompatible with crucible-llvm's upper bounds (where crucible-llvm is also vendored in via a submodule). These submodules would need to be updated in tandem.

@mccleeary-galois mccleeary-galois merged commit 788d97d into master Jun 12, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update llvm-pretty submodule location
3 participants