Build x86-64 macOS solvers on macos-13
#52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`gcc-14` or later will complain about missing header files that aren't explicitly `#include`d. (See bitwuzla/bitwuzla#118.) This was fixed upstream in bitwuzla/bitwuzla@31330f2, so this backports the fix to the version of `bitwuzla` that `what4-solvers` currently builds.
For whatever reason, the version of `clang++` included in `macos-14` is pickier about needing explicit `#include <cstddef>` statements than `macos-13` is (or any other operating system is, for that matter). This adds a `.patch` file to add these missing `#include` statements.
RyanGlScott
force-pushed
the
T51-macos-13
branch
2 times, most recently
from
76c7bca
to
531431b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51.