Support building with GHC 9.10 #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump the upper version bounds on `base` in the various `what4` packages, and bump the `aig` submodule to bring in the changes from GaloisInc/aig#18.
`base-4.20` (GHC 9.10) re-exports `foldl'` from the `Prelude`, which conflicts with the `foldl'` function defined in `What4.Utils.Word16String`. To avoid conflicts, we re-export `What4.Utils.Word16String.foldl'` using a qualified export, which avoids warnings in a backwards-compatible fashion. Fixes #272.
This ensures that the `zlib` version is consistent with the rest of the packages offered by `nixpkgs`.
RyanGlScott
force-pushed
the
T272-ghc-9.10
branch
from
35046fc to
ad0b318
Compare
kquick
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
base-4.20(GHC 9.10) re-exportsfoldl'from thePrelude, which conflicts with thefoldl'function defined inWhat4.Utils.Word16String. To avoid conflicts, we re-exportWhat4.Utils.Word16String.foldl'using a qualified export, which avoids warnings in a backwards-compatible fashion.We also fix a variety of
-Wunused-importswarnings caused by the same change and add GHC 9.10.1 to CI.Fixes #272.