feat: upgrade to graphqlws #1424
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasburtey
force-pushed
the
update-graphqlws
branch
6 times, most recently
from
d905bbc to
d3246a3
Compare
nicolasburtey
force-pushed
the
update-graphqlws
branch
6 times, most recently
from
24d49c5 to
1cd6d85
Compare
nicolasburtey
force-pushed
the
update-graphqlws
branch
2 times, most recently
from
749d93c to
99e4509
Compare
nicolasburtey
force-pushed
the
update-graphqlws
branch
from
99e4509 to
53a0911
Compare
may need more work for cross compatibility with older transport library that is being used in the mobile repo
otherwise there seems to be a critical js error happening, at least on the CI server. probably some minor package update that has a regression/incompatibility
nicolasburtey
force-pushed
the
update-graphqlws
branch
from
53a0911 to
7480458
Compare
|
legacy server (when no env variable is set) --> api.mainnet.galoy.io |
|
migrating in favor of #1424 (a squash to simplify the rebase) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1365, plus some security consideration using the old library: enisdenjo/graphql-ws#3
I ran into issues when I was importing both
subscriptions-transport-wsandgraphql-wsat the same time. instead of trying to understand the root of this, I decided to duplicated graphql-server and dynamically, at runtime, one or the other websocket library would be used.by default the old library would be used - so that we can enable the use of the new library in another PR in the charts/deployment repo.
I recommend that we use a new url for BBW to do the migration from the mobile app. we could use api.bbw.sv to replace the current url. api.bbw.sv would have the
graphql-wslibrary. mainnet.graphql.galoy.io would have thesubscriptions-transport-wslibrary.