Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1365, plus some security consideration using the old library: enisdenjo/graphql-ws#3
I ran into issues when I was importing both subscriptions-transport-ws and graphql-ws at the same time. instead of trying to understand the root of this, I decided to duplicated graphql-server and dynamically, at runtime, one or the other websocket library would be used.
by default the old library would be used - so that we can enable the use of the new library in another PR in the charts/deployment repo.
I recommend that we use a new url for BBW to do the migration from the mobile app. we could use api.bbw.sv to replace the current url. api.bbw.sv would have the graphql-ws library. mainnet.graphql.galoy.io would have the subscriptions-transport-ws library.
legacy server (when no env variable is set) --> api.mainnet.galoy.io
"new" server (when NEW_SERVER is set) --> api.bbw.sv
note: I didn't see there was a way to do backward compability with both subscription services
ws server usage with subscriptions-transport-ws backwards compatibility