perf(core): update mongodb default connection settings #4646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolcalmi
commented
Nov 5, 2024
| @@ -29,9 +29,7 @@ const getWalletBalance = async (account: string, query = {}) => { | |||
|
|
|||
| const balancePromise = (async () => { | |||
| try { | |||
| const { balance } = await MainBookAdmin.balance(params, { | |||
| readPreference: "secondaryPreferred", | |||
There was a problem hiding this comment.
now it is not required because readPreference is setup at server level
dolcalmi
commented
Nov 5, 2024
| { | ||
| account: liabilitiesWalletId, | ||
| }, | ||
| { readPreference: "primaryPreferred" }, |
There was a problem hiding this comment.
now it is not required because readPreference default value is primaryPreferred
openoms
reviewed
Nov 6, 2024
Comment on lines
+25
to
+48
| const DEFAULT_MONGODB_OPTIONS: mongoose.ConnectOptions = { | ||
| autoIndex: false, | ||
| compressors: ["snappy", "zlib"], | ||
|
|
||
| maxPoolSize: 100, | ||
| minPoolSize: 15, | ||
| maxConnecting: 5, // Maximum number of concurrent connection attempts | ||
|
|
||
| socketTimeoutMS: 60000, // Close sockets after 60 seconds of inactivity | ||
| connectTimeoutMS: 15000, // Give up initial connection after 15 seconds | ||
| serverSelectionTimeoutMS: 15000, // Keep trying to send operations for 15 seconds | ||
|
|
||
| retryWrites: true, | ||
| writeConcern: { | ||
| w: "majority", // Wait for majority acknowledgment | ||
| j: true, // Wait for journal commit | ||
| wtimeout: 10000, // Write timeout | ||
| }, | ||
|
|
||
| retryReads: true, | ||
| maxStalenessSeconds: 90, | ||
| readPreference: "primaryPreferred", // Prefer primary but allow secondary reads | ||
| readConcern: { level: "majority" }, // Read from majority-committed data | ||
| } as const |
There was a problem hiding this comment.
Compared the defaults there is compression introduced and more connections with bigger pool sizes, these settings expected to increase the performance.
Can you link the baseline you are comparing to?
Then in writeConcern and readConcern these settings should improve the consistency, hopefully not with too much tradeoff in performance.
openoms
approved these changes
Nov 6, 2024
This was referenced Nov 6, 2024
This was referenced Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.