fix: detect lightning param in bip 21 QR codes #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samerbuna
reviewed
May 30, 2022
src/parsing/index.ts
Outdated
| errorMessage: `Invalid lightning invoice for ${network} network`, | ||
| } | ||
| } | ||
| const dataToDecode = getDataToDecode(destinationText) |
There was a problem hiding this comment.
Maybe pass protocol to getLightningPayResponse too (like getIntraLedgerPayResponse) and avoid doing this again?
There was a problem hiding this comment.
I didn't feel comfortable passing in protocol since I needed it for getLNParam, but pointing this out did help me remove this duplicate function we didn't need.
samerbuna
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses this issue, where we do not recognize the lightning param in BIP 21 QR codes.
In completing this work, I refactored the
parsePaymentDestinationmethod. The existing logic seemed to initially determine the paymentType, and then create the payment response based on this type. I attempted to reflect this approach through some new functions.All existing test cases pass, and I added a case for this specific piece of functionality, as well as a couple other cases we were missing.