Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce performance overhead of directional shadow support #1345

Open
tomas7770 opened this issue Oct 12, 2024 · 2 comments
Open

Reduce performance overhead of directional shadow support #1345

tomas7770 opened this issue Oct 12, 2024 · 2 comments

Comments

@tomas7770
Copy link
Contributor

Description

The newly added support for directional lights casting shadows has resulted in a drastic performance loss (about half in some cases), even when shadows aren't enabled, due to changes in the deferred shading.

Expected behaviour

When shadows are disabled, the performance impact of merely supporting them should be minimal.

@tomas7770 tomas7770 added A-Engine B-Rendering S-Triage Issues whose priority still has to be figured out C-Optimization labels Oct 12, 2024
@RiscadoA
Copy link
Member

Damn we really need to improve this on 0.5 💀 samples become outright unplayable on my laptop

@RiscadoA RiscadoA added this to the 0.5 milestone Oct 13, 2024
@RiscadoA RiscadoA removed the S-Triage Issues whose priority still has to be figured out label Oct 13, 2024
@tomas7770
Copy link
Contributor Author

tomas7770 commented Oct 14, 2024

Lowering the max number of cascades and/or removing the directional light greatly improves performance on my laptop. Adding more directional lights worsens it. Maybe the bottleneck is passing the cascade matrices to the GPU?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants