Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spdlog can't be updated to versions after v1.9.1 #619

Closed
luishfonseca opened this issue Sep 29, 2023 · 1 comment
Closed

Spdlog can't be updated to versions after v1.9.1 #619

luishfonseca opened this issue Sep 29, 2023 · 1 comment
Labels
A-Core B-Build Related to the build configuration C-Bug

Comments

@luishfonseca
Copy link
Contributor

luishfonseca commented Sep 29, 2023 •
edited
Loading

Description

CUBOS. will fail to compile recent spdlog versions

Reproduce

Steps to reproduce the behavior:

  1. Checkout the spdlog submodule at v1.10.0
  2. Try to compile

Expected behaviour

It should compile

Additional context

Fixing this would also allow to use the system installed spdlog instead of building it.
There's also some weird interference with fmt that blocks it from being updated to recent versions.
These errors can be seen on this action run
@luishfonseca luishfonseca added the S-Triage Issues whose priority still has to be figured out label Sep 29, 2023
@luishfonseca luishfonseca changed the title Spdlog can't be updated to versions after v1.9.0 Spdlog can't be updated to versions after v1.9.1 Sep 29, 2023
@luishfonseca luishfonseca mentioned this issue Sep 30, 2023
Open
4 tasks
@RiscadoA RiscadoA added A-Core B-Build Related to the build configuration C-Bug and removed S-Triage Issues whose priority still has to be figured out labels Sep 30, 2023
@RiscadoA RiscadoA self-assigned this Sep 30, 2023
@RiscadoA RiscadoA removed their assignment Nov 4, 2023
@roby2014
Copy link
Member

Closing this because #823 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Core B-Build Related to the build configuration C-Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@RiscadoA @roby2014 @luishfonseca