Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement telemetry #620

Open
3 of 4 tasks
luishfonseca opened this issue Sep 30, 2023 · 3 comments
Open
3 of 4 tasks

Implement telemetry #620

luishfonseca opened this issue Sep 30, 2023 · 3 comments

Comments

@luishfonseca
Copy link
Contributor

luishfonseca commented Sep 30, 2023

Checklist

Problem

We aren't using any spdlog specific features, and it's a problematic dependency (#619), we should remove it.
As we are working on this, would also be good to expand telemetry to metrics and tracing.

Design

  • Superset of current logging interface
  • Lightweight
  • Consumable by 3rd party tooling
@luishfonseca luishfonseca added C-Tracking-Issue S-Triage Issues whose priority still has to be figured out labels Sep 30, 2023
@RiscadoA RiscadoA added A-Core B-Telemetry and removed S-Triage Issues whose priority still has to be figured out labels Sep 30, 2023
@roby2014
Copy link
Member

What is meant by tracing here? @luishfonseca @RiscadoA . Do we want something like https://docs.rs/tracing/latest/tracing/ ?

@RiscadoA
Copy link
Member

Yeah that's what I had in mind, some kind of system where you could define scopes, and then you could filter log messages and metrics from it, perhaps? But yeah, I'm not really sure what we need here, maybe @luishfonseca has some clearer idea.

@luishfonseca
Copy link
Contributor Author

Tbh I don't really remember what was the plan, I'm actually not that used to tracing in single machine applications, what does it achieve that we can't just do with logs and metrics?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants