fix(engine): move ImGui::End call to outside of if body

[SrGesus]

Description

Moved ImGui::End call to outside of if body.

Context

ImGui::End call was inside an if statement, meaning it would not be executed sometimes despite ImGui::Begin being called, this results in a crash.

Checklist

• Self-review changes.
• Evaluate impact on the documentation.
• Ensure test coverage.
• Write new samples.
• Add entry to the changelog's unreleased section.

[github-actions]

PR Preview Action v1.4.8
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/preview/pr-1353/
on branch gh-pages at 2024-10-22 23:32 UTC

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 41.54%. Comparing base (86781d5) to head (6ba04f3).

Files with missing lines	Patch %	Lines
engine/src/tools/play_pause/plugin.cpp	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1353   +/-   ##
=======================================
  Coverage   41.54%   41.54%           
=======================================
  Files         437      437           
  Lines       32850    32850           
  Branches     3820     3820           
=======================================
  Hits        13646    13646           
  Misses      19204    19204           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[RiscadoA]

LGTM! Don't forget to add an entry to the changelog 😌

[SrGesus]

LGTM! Don't forget to add an entry to the changelog 😌

Haha I'd thought it was too little of a contribution to add it

[RiscadoA]

LGTM! Don't forget to add an entry to the changelog 😌

Haha I'd thought it was too little of a contribution to add it

Still a fix though, gotta get that credit 👀

[RodrigoVintem]

Codecov / codecov/patch

engine/src/tools/play_pause/plugin.cpp#L58

Added line #L58 was not covered by tests

Isto não será importante?

[RiscadoA]

Codecov / codecov/patch

engine/src/tools/play_pause/plugin.cpp#L58

Added line #L58 was not covered by tests

Isto não será importante?

Bem apanhado! Infelizmente a maioria do engine não está coberto pelos testes 😔
É basicamente só porque é mesmo muito dificil testar coisas 'gráficas' automaticamente, por isso we don't really do it.
Isto é um desses casos, já que a feature de que estamos a falar é o engine crashar quando uma janela da interface de debug é escondida (iirc)

Mas yeah, de resto, quando é algo deterministico e não demasiado dificil de testar, é sempre bom tentar cobrir com testes.