Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update default gamemode='1' and address the issue #2031 #2442

Closed
wants to merge 2 commits into from
Closed

Conversation

ohbus
Copy link

@ohbus ohbus commented Jul 12, 2019

commit 0db1e2f deals with updating the default gamemode='1' to start the server as a competitive match rather than a casual match.

and

commit 0971a64 deals with #2031 and servers to solve the issue with adding sv_lan 0 and sv_cheats 0 explicitly under the default starting parameters argument list.

ohbus added 2 commits July 12, 2019 13:18
updated the default gamemode value to '1' to start the server as a competitive match rather than a casual match.
added the 'sv_lan 0' which refers to INTERNET mode play whereas 'sv_lan 1' represents ONLY LAN mode play - VAC(Valve Anti Cheat) is turned off when it's value is 1
added 'sv_cheats 0' as default starting parameters which explicitly restricts any player from taking any unfair advantage for the game over other players, whereas 'sv_cheats 1' enables users for special powers such as 'god' and 'noclip'
@ohbus ohbus changed the title update default gamemode='1' update default gamemode='1' and address #2031 Jul 12, 2019
@ohbus ohbus changed the title update default gamemode='1' and address #2031 update default gamemode='1' and address #2031 Jul 12, 2019
@ohbus ohbus changed the title update default gamemode='1' and address #2031 update default gamemode='1' and address the issue #2031 Jul 12, 2019
@h3o66
Copy link
Member

h3o66 commented Jul 15, 2019

imho I would prefer only to take the second commit for the sv_lan changes and sv_cheats.
I guess it is not wanted to change all gameservers that use the current default for the servers that were already set up some time ago

@ohbus
Copy link
Author

ohbus commented Jul 16, 2019

imho I would prefer only to take the second commit for the sv_lan changes and sv_cheats.
I guess it is not wanted to change all gameservers that use the current default for the servers that were already set up some time ago

OK I understand your concern, then shall I remove the first commit?

@ohbus
Copy link
Author

ohbus commented Jul 28, 2019

imho I would prefer only to take the second commit for the sv_lan changes and sv_cheats.
I guess it is not wanted to change all gameservers that use the current default for the servers that were already set up some time ago

When I had setup the server with my friends, All of them suggested that the default game mode should be changed to competitive as that is the most widely played game mode and most preferred way of playing even with custom maps like 5v5 Retake Servers.

i hope you understand the concern and merge this commit for the good of the counter strike community where I believe this should have been default playing mode in the game as done by the default vanilla in-game screen as well.

@borzaka
Copy link
Contributor

borzaka commented Aug 1, 2019

sv_lan and sv_cheats are already in the csgoserver game server configs:
https://github.com/GameServerManagers/Game-Server-Configs/blob/master/CounterStrikeGlobalOffensive/server.cfg

No need to set it via command line as well. Option to set these in two places is a bad practice. They can override each other. As in the #2031, even in the official documentation they setup these values in the config file, not in the command line.

I agree with the default game mode set to competitive.

GitHub
A repo of game server configuration files. Contribute to GameServerManagers/Game-Server-Configs development by creating an account on GitHub.

@ohbus
Copy link
Author

ohbus commented Aug 2, 2019

sv_lan and sv_cheats are already in the csgoserver game server configs:
https://github.com/GameServerManagers/Game-Server-Configs/blob/master/CounterStrikeGlobalOffensive/server.cfg

No need to set it via command line as well. Option to set these in two places is a bad practice. They can override each other. As in the #2031, even in the official documentation they setup these values in the config file, not in the command line.

I agree with the default game mode set to competitive.

GitHub**GameServerManagers/Game-Server-Configs**A repo of game server configuration files. Contribute to GameServerManagers/Game-Server-Configs development by creating an account on GitHub.

Okay!

I did not notice that those config files are used when the server got deployed.

Assumed it to be some side project.

Thank You @borzaka for bringing up.

GitHub
A repo of game server configuration files. Contribute to GameServerManagers/Game-Server-Configs development by creating an account on GitHub.

@ohbus ohbus closed this Aug 2, 2019
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants