Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix permissions on Bid v2 endpoint [#186384302] #614

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

uraniumanchor
Copy link
Collaborator

Contributing to the Donation Tracker

  • I've added tests or modified existing tests for the change.
  • I've humanly end-to-end tested the change by running an instance of the tracker.

Issue from Pivotal Tracker

https://www.pivotaltracker.com/story/show/186384302

Description of the Change

This is a more complete version of #604, I couldn't merge that one for two reasons:

  • our CI doesn't let the tests pass because of a permissions check that non-collabs can't pass (we'll need to address this later)
  • no tests were added or fixed that would have exposed the problem

This was fixed on the hotfix branch a while back but a) I forgot to merge it back into master and b) I never updated the tests to actually do the test correctly (they were spuriously passing because superuser, I need to go through and make sure no other tests are doing that).

Verification Process

The fix has been on the real server for a while, plus I manually verified it again locally.

@uraniumanchor uraniumanchor added this pull request to the merge queue Nov 1, 2023
Merged via the queue into master with commit 367c7d0 Nov 1, 2023
15 checks passed
@uraniumanchor uraniumanchor deleted the 186384302-bid-permissions-check branch November 1, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant