Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParseReqsInDirectory doesn't exclude stray sub-REQs #4

Closed
marth8880 opened this issue Jan 20, 2018 · 2 comments
Closed

ParseReqsInDirectory doesn't exclude stray sub-REQs #4

marth8880 opened this issue Jan 20, 2018 · 2 comments
Assignees
Labels

Comments

@marth8880
Copy link
Collaborator

If a side (for example) is added to the list and there are REQs in its asset directory that aren't listed in the side's main REQ's LVL chunk, those REQs are added to the Munged Files list.

EXPECTED:

Sub-LVLs and stray REQs are excluded from the Munged Files list.

@marth8880
Copy link
Collaborator Author

Problem with fixing this is the whole point of adding stray REQs that aren't listed as sub-LVLs, which is to make it so a user can add a world that has multiple LVLs (e.g., the main LVL and a sky LVL).

Might create a fix for this that doesn't apply to munging worlds, but putting on the backburner for now.

@marth8880 marth8880 removed the wontfix label Mar 11, 2018
marth8880 added a commit that referenced this issue Mar 11, 2018
…anged Side parser to only search for REQs in the side's top folder
@marth8880
Copy link
Collaborator Author

Issue fixed in 69ef51d - closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant