Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for rust-lang/rust#80127 #15

Closed
bjorn3 opened this issue Dec 2, 2022 · 2 comments · Fixed by #40
Closed

Add test for rust-lang/rust#80127 #15

bjorn3 opened this issue Dec 2, 2022 · 2 comments · Fixed by #40
Labels
test-request Add a test to the suite for this

Comments

@bjorn3
Copy link
Contributor

bjorn3 commented Dec 2, 2022

rust-lang/rust#80127 is an issue where stack arguments with a 16-byte alignment are passed at the wrong offset.
@Gankra
Copy link
Owner

Gankra commented Jun 30, 2024

As of #20:

  • @align 16 is ostensibly supported in kdl-script, the new test format
    • the rust backend knows how to generate it, although I haven't actually tested it
    • the C backend doesn't know how to generate it, and will skip if it sees any attrs, but we could add it

@Gankra Gankra mentioned this issue Jun 30, 2024
Closed
@Gankra
Copy link
Owner

Gankra commented Jun 30, 2024

Filed #26 for the main blocker

@Gankra Gankra added the test-request Add a test to the suite for this label Jun 30, 2024
Gankra added a commit that referenced this issue Jul 1, 2024
@Gankra
fix some wrong tests and add some new ones
01cd394 
Note that C still doesn't implement align, but as of #39 we combinatoric repr(rust) vs repr(c) and include rustcall as a calling convention, so our coverage of rust <-> rust (in particular for codegen_backend users) is significantly improved.

fixes #23
fixes #21
fixes #15
@Gankra Gankra mentioned this issue Jul 1, 2024
Merged
@Gankra Gankra closed this as completed in #40 Jul 1, 2024
@Gankra Gankra closed this as completed in dd37470 Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test-request Add a test to the suite for this
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix some wrong tests and add some new ones Gankra/abi-cafe
2 participants
@Gankra @bjorn3