Prototype Dlist rewrite with cursor #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cursor stuff is now implemented. I believe it also fully handles pcwalton's usecase, now. |
|
|
||
| /// Converts the ref to an Option containing a reference. | ||
| #[inline] | ||
| fn as_ref(&self) -> Option<& Node<T>> { |
There was a problem hiding this comment.
Unfortunately, this still isn't safe:
let raw = {
let mut node = Node::new(1u);
Raw::some(&mut node)
};
// Now the node is dead. However, we can still access it.
let ref = raw.as_ref().unwrap();There was a problem hiding this comment.
Yeah, totally. Still safer than std::DList (can't promote &DList to &mut DList), but not Safe. Littering everything with unsafe is super shitty, though, and I don't see any reasonable way to make DList safe. :(
There was a problem hiding this comment.
I mean, we could just make Raw::some unsafe and say "be careful with raws".
|
This isn't perfect by any means, but I want to land this so people can play around with it. This library is about experiments. |
Gankra
added a commit
that referenced
this pull request
Dec 15, 2014
Prototype Dlist rewrite with cursor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.