Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UNEXPECTED_TRANSLATIONS_DATA rule implementation #247

Closed
buchslava opened this issue Oct 28, 2016 · 1 comment
Closed

UNEXPECTED_TRANSLATIONS_DATA rule implementation #247

buchslava opened this issue Oct 28, 2016 · 1 comment

Comments

@buchslava
Copy link
Collaborator

buchslava commented Oct 28, 2016

  • Rule name: Should be filled if this issue depends on particular rule especially during new rule creation. This name should be a valid JS variable name and should be used for connecting with code.

UNEXPECTED_TRANSLATIONS_HEADER

  • Rule test folder: Should be filled if type of Request is rule. Needed for documentation auto generation.

test/fixtures/rules-cases/unresolved-translations

  • Rule description: Should be filled if type of Request is rule. Needed for documentation auto generation.

Non consistent (empty) data in primary-key fields.

  • Examples of correct data:

ddf--translation--en-us--datapoints--gov_type--by--geo--year.csv
and
ddf--datapoints--gov_type--by--geo--year.csv

  • Examples of incorrect data:

ddf--translation--en-us--datapoints--gov_type--by--geo--foo.csv
and
ddf--datapoints--gov_type--by--geo--year.csv

  • Notes

This rule should be applied only for indexless dataset.

@jheeffer
Copy link
Member

This rule is also for indexed dataset! Any dataset.

buchslava added a commit that referenced this issue Nov 1, 2016
@buchslava buchslava changed the title UNRESOLVED_TRANSLATIONS rule implementation UNEXPECTED_TRANSLATIONS_HEADER rule implementation Nov 11, 2016
@buchslava buchslava changed the title UNEXPECTED_TRANSLATIONS_HEADER rule implementation UNEXPECTED_TRANSLATIONS_DATA rule implementation Nov 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment