Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRONG_INDEX_VALUE rule providing #71

Closed
buchslava opened this issue May 5, 2016 · 1 comment
Closed

WRONG_INDEX_VALUE rule providing #71

buchslava opened this issue May 5, 2016 · 1 comment

Comments

@buchslava
Copy link
Collaborator

buchslava commented May 5, 2016

  • Rule name: Should be filled if this issue depends on particular rule especially during new rule creation. This name should be a valid JS variable name and should be used for connecting with code.

WRONG_INDEX_VALUE

  • Rule test folder: Should be filled if type of Request is rule. Needed for documentation auto generation.

test/fixtures/rules-cases/wrong-index-value

  • Rule description: Should be filled if type of Request is rule. Needed for documentation auto generation.

An issue according to this rule will be fired when index value breaks next smaller rules:

  • concept and entity should contain a valid part of header
  • datapoint should contain measure or measures
  • Examples of correct data:

ddf--index.csv

key,value,file
concept,name,ddf--concepts.csv
concept,concept_type,ddf--concepts.csv
concept,domain,ddf--concepts.csv
concept,indicator_url,ddf--concepts.csv
concept,color,ddf--concepts.csv
concept,scales,ddf--concepts.csv
concept,drill_up,ddf--concepts.csv
concept,unit,ddf--concepts.csv
concept,interpolation,ddf--concepts.csv
concept,description,ddf--concepts.csv
"geo,time",age_at_1st_marriage_women,ddf--datapoints--age_at_1st_marriage_women--by--geo--time.csv
landlocked,name,ddf--entities--geo--landlocked.csv
  • Examples of incorrect data:

ddf--index.csv

key,value,file
concept,foo1,ddf--concepts.csv
"geo,time",foo2,ddf--datapoints--age_at_1st_marriage_women--by--geo--time.csv
landlocked,foo3,ddf--entities--geo--landlocked.csv

where
foo1-3 are not valid concepts

  • Scenarios Should be filled if type of Request is rule.
when dataset is correct
  any issue should NOT be found for this rule
when dataset is NOT correct
  issues in accordance with wrong values quantity should be detected for this rule
  output data for any issue should be expected
  • Output data format Additional data that depends on particular issue type. Should be filled if type of Request is rule.

line with data/record
wrong value

@jheeffer
Copy link
Member

jheeffer commented May 9, 2016

So index key and value should always be concepts. Yes! Good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants