Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching to a higher marker space: labels only show countries #246

Open
angiehjort opened this issue Oct 13, 2021 · 0 comments
Open

Switching to a higher marker space: labels only show countries #246

angiehjort opened this issue Oct 13, 2021 · 0 comments
Assignees

Comments

@angiehjort
Copy link
Member

  1. data comes from harmonised sources, such as SG and Fasttrack
  2. data comes from disharmonised sources, such as SG and a csv file with higher dimensionality

vizabi core assumes that datasets from all sources are harmonised...
which means it's easy to get labels for country, gender when country comes from SG and gender from fasttrack because both datasets have country and gender entities with their names available, so you request either one, no problem
however in case when i'm adding a csv by country, decile, other datasets don't have decile entities and their names, therefore vizabi can't get those. it needs to know that space can be composed of concepts coming from different datasources (edited)

@angiehjort angiehjort self-assigned this Oct 13, 2021
angiehjort added a commit to vizabi/shared-components that referenced this issue Oct 13, 2021
...so that the space won't get changed to a subspace. Fixes an issue with missing gender labels when switching to country-gender marker space.

Gapminder/tools-page#246
angiehjort added a commit to vizabi/core that referenced this issue Oct 13, 2021
This is a more stable way to compose a label space in the presence of readers who may have a clue about which one is a "time" concept type but not about entity domains and sets

Gapminder/tools-page#246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant