Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: REM-17592 new tenant updated messages and new tenant fields #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

btihen
Copy link
Contributor

@btihen btihen commented Jan 23, 2024

Discussion points:
I made a few fields that may be unnecessary in some cases, but felt it was simpler for both the code and the API to keep things always the same, for example

  1. tenantReference: (the reference that can used to identify the record) - tenant.reference may change if the tenant was merged into another record.
  2. tenant: {} - it is slightly simpler (in my mind) to always use the same structure (and code) for Tenancy.Created, Tenant.Updated and Tenant.Merged. In this way the data is always structured the same between GraphQL and Mbus.
  3. Do we really need both: Tenant.Updated and Tenant.Merged - I feel like just Tenant.Updated is enough. The advantage is that Tenant.Merged helps call out the change in the reference and that all data will be sent, however, I think a simple one-line description can clarify these minor differences.
  4. email and phoneNumber - is it a problem for existing customers of mbus to change the logic to be consistent with GraphQL
  5. Adding Address - changes looks to be a bit more complex as it looks like there are several ways an address can change, is this indeed worthwhile? (we can update an Address on a Haus record ( http://localhost:3000/haeuser/5087/haus_grunddaten/edit this address could also be associated with a person) on a person record it looks like we can create a new addresses (http://localhost:3000/personen/588778/adressaenderung/new), but not change them. What are all the Address change possibilities that would affect a 'Tenant'?

I look forward to ideas and refinements.

@btihen btihen changed the title feat: new tenant updated messages and new tenant fields feat: REM-17592 new tenant updated messages and new tenant fields Jan 23, 2024
@gernotkogler gernotkogler self-requested a review January 23, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants