Bugfixes for LPMP #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @grg-haas! Thanks for your time. I took a look at the changes and built it again in my local environment. It is working well on my machine, but I only tested for the 64-bit platform. We also learnt some coding conventions from this PR and we will try to follow them in future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly fixes CI builds for our platforms, while also doing some light refactoring. Specifically, I moved the contents of the
sbi-lpmp.cfile out ofopensbi-lpmp.patch, since it is easier/more maintainable to keep track of source code changes than patch file changes. Also, I added support for 32-bit builds since it seems this patchset was originally developed for 64-bit platforms.NOTE: this patch has not been tested for correctness yet -- I mainly just went through and fixed compile bugs. If y'all have the spare capacity, I would really appreciate it if you could take a look at these changes and make sure I didn't break anything, both for 64-bit and 32-bit. If you don't have the time, that's of course also okay -- just let me know and I can find some time to take a look.
Next steps for getting LPMP merged into Keystone would be merging my PR into your PR, we'll then do an informal security review (since this touches security-critical functionality for Keystone) and go from there! Thanks again for your contribution!