Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move validate methods to new class-validate.php #865

Closed
mauteri opened this issue Sep 7, 2024 · 1 comment · Fixed by #883
Closed

Move validate methods to new class-validate.php #865

mauteri opened this issue Sep 7, 2024 · 1 comment · Fixed by #883
Labels
good first issue Good for newcomers
Milestone

Comments

@mauteri
Copy link
Contributor

mauteri commented Sep 7, 2024

Currently there are a bunch validate methods in class-event-rest-api.php that I'd like to move to a general validate class.

We can remove the validate_ prefix from these methods when we move them. Make them static methods, eg, validate_event_post_id method will be Validate::event_post_id.

Unit tests will need to be moved as well.

@mauteri mauteri converted this from a draft issue Sep 7, 2024
@mauteri mauteri added the good first issue Good for newcomers label Sep 7, 2024
@mauteri mauteri added this to the 0.31.0 milestone Sep 7, 2024
@JordanPak
Copy link
Contributor

I'ma take a shot at this one :)

mauteri added a commit that referenced this issue Sep 19, 2024
Issue #865: Refactor REST API validation to its own class
@github-project-automation github-project-automation bot moved this from In Progress to Done in GatherPress Project Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Development

Successfully merging a pull request may close this issue.

2 participants